Fix for smp request crash/hang on Adaptec adapters #1
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2021 17:13
send_req_aac correctly calculates the maximum response size it can process at a time with a 512 byte FIB data buffer, but inadvertanly ignores this value and uses the full response length in the response memcpy, corrupting memory when the response is greater than 512 bytes [minus headers] as with eg zone control requests.
Although the gpio utils already initialize the i_params buffers, the other utilities do not. In several places (eg, in smp_initiator_open) this results in request decisions being made based on preexisting stack contents when no interface parameter is explicitly specified. Patch kills this pattern globally and always initializes i_params.
xiphmont
changed the title
|
Applied those fixes by hand on my local subversion repository and uploaded them here. Thanks for your input, sorry for the delay, expected to get an email from github as with some other repositories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
Correct a serious memcpy bounds error causing all > 512 byte responses to crash the request and hang the aac interface. For example, this prevents zoning configuration requests from succeeding.
Fix a minor argument problem where checking for an unset i_params variable is branching based on stack garbage. This is relevant when -I is intuited rather than explicit.